Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize the way to get configuration in DB mode of console #4469

Merged
merged 6 commits into from
Mar 19, 2022

Conversation

lvekee
Copy link
Contributor

@lvekee lvekee commented Mar 14, 2022

Ⅰ. Describe what this PR did

optimize the way to get configuration in DB mode of console

@lvekee lvekee changed the title optimize: modify acquisition configuration method optimize: optimize the way to get configuration in DB mode of console Mar 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #4469 (e118b1b) into develop (ac12355) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4469      +/-   ##
=============================================
- Coverage      49.04%   48.92%   -0.12%     
+ Complexity      4030     4028       -2     
=============================================
  Files            730      730              
  Lines          25282    25309      +27     
  Branches        3130     3136       +6     
=============================================
- Hits           12399    12382      -17     
- Misses         11556    11604      +48     
+ Partials        1327     1323       -4     
Impacted Files Coverage Δ
...er/console/impl/db/BranchSessionDBServiceImpl.java 0.00% <0.00%> (ø)
...erver/console/impl/db/GlobalLockDBServiceImpl.java 0.00% <0.00%> (ø)
...er/console/impl/db/GlobalSessionDBServiceImpl.java 0.00% <0.00%> (ø)
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50.00% <0.00%> (-6.12%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	changes/1.5.0.md
#	changes/en-us/1.5.0.md
@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 18, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 262b26b into apache:develop Mar 19, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants