Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize : optimize debug log and fix typo #4477

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Mar 16, 2022

Ⅰ. Describe what this PR did

shutdownhook类的单词拼写有误,log.debug也没有判断enable
GlobalSessionRedisServiceImpl的log.debug之前有一些逻辑但都是为了打日志,这个也没有enable判断

Ⅱ. Does this pull request fix one issue?

#4476

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Bughue
Copy link
Contributor Author

Bughue commented Mar 16, 2022

还发现有几个类的log.debug有这种情况的,是不是一起在这个pr修了

@Bughue Bughue changed the title optimize : shutdownhook log.debug and word misspelled optimize : log.debug and word misspelled Mar 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #4477 (08d10e4) into develop (193a112) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4477      +/-   ##
=============================================
- Coverage      49.09%   48.98%   -0.11%     
+ Complexity      4032     4028       -4     
=============================================
  Files            730      730              
  Lines          25278    25281       +3     
  Branches        3126     3129       +3     
=============================================
- Hits           12411    12385      -26     
- Misses         11545    11573      +28     
- Partials        1322     1323       +1     
Impacted Files Coverage Δ
.../src/main/java/io/seata/core/rpc/ShutdownHook.java 72.97% <0.00%> (-9.89%) ⬇️
...sole/impl/redis/GlobalSessionRedisServiceImpl.java 0.00% <0.00%> (ø)
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50.00% <0.00%> (-6.84%) ⬇️
...erver/storage/file/session/FileSessionManager.java 52.28% <0.00%> (-1.97%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 32.25% <0.00%> (+1.61%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize : log.debug and word misspelled optimize : optimize debug log and fix typo Mar 16, 2022
@slievrly slievrly merged commit 3d36af9 into apache:develop Mar 16, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants