Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize nacos config and naming properties #4478

Merged
merged 2 commits into from
Mar 17, 2022
Merged

optimize: optimize nacos config and naming properties #4478

merged 2 commits into from
Mar 17, 2022

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Mar 16, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize: optimize nacos config and naming properties

  • The problem that Seata cannot use the real registry when the registry of RPC or Rest services is not the same as Seata's and the service's registry uses the -D(-D tenant.id)startup parameter to specify the highest priority access for Nacos metadata.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4478 (c340b16) into develop (80dd842) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4478   +/-   ##
==========================================
  Coverage      49.09%   49.09%           
  Complexity      4033     4033           
==========================================
  Files            730      730           
  Lines          25281    25281           
  Branches        3130     3130           
==========================================
  Hits           12412    12412           
+ Misses         11545    11544    -1     
- Partials        1324     1325    +1     
Impacted Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
.../java/io/seata/spring/util/TCCBeanParserUtils.java 30.64% <0.00%> (-1.62%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

@slievrly slievrly added this to the 1.5.0 milestone Mar 17, 2022
@slievrly slievrly merged commit 61cac63 into apache:develop Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants