Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: TCC mode supports tcc annotation marked on both interface and implementation class #4479

Merged
merged 11 commits into from Aug 17, 2022
Merged

feature: TCC mode supports tcc annotation marked on both interface and implementation class #4479

merged 11 commits into from Aug 17, 2022

Conversation

yujianfei1986
Copy link
Contributor

@yujianfei1986 yujianfei1986 commented Mar 17, 2022 •
edited by wangliang181230

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

TCC注解支持添加在实现类及其方法上也生效

Ⅱ. Does this pull request fix one issue?

无

Ⅲ. Why don't you add test cases (unit test/integration test)?

不需要

Ⅳ. Describe how to verify it

新feature

Ⅴ. Special notes for reviews

核心代码变更：LocalTCCRemotingParser

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022 •
edited

Codecov Report

Merging #4479 (b376d14) into develop (8ace7ab) will increase coverage by 0.18%.
The diff coverage is 20.51%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4479      +/-   ##
=============================================
+ Coverage      49.17%   49.35%   +0.18%     
- Complexity      4091     4114      +23     
=============================================
  Files            737      737              
  Lines          25745    25750       +5     
  Branches        3180     3181       +1     
=============================================
+ Hits           12660    12709      +49     
+ Misses         11736    11693      -43     
+ Partials        1349     1348       -1
Impacted Files Coverage Δ
...java/io/seata/spring/tcc/TccActionInterceptor.java 14.00% <0.00%> (ø)
...va/io/seata/spring/tcc/TccAnnotationProcessor.java 0.00% <0.00%> (ø)
.../rm/tcc/remoting/parser/DefaultRemotingParser.java 23.80% <0.00%> (ø)
...ta/rm/tcc/remoting/parser/DubboRemotingParser.java 3.84% <0.00%> (ø)
...eata/rm/tcc/remoting/parser/HSFRemotingParser.java 7.69% <0.00%> (ø)
.../rm/tcc/remoting/parser/SofaRpcRemotingParser.java 4.54% <0.00%> (ø)
...rm/tcc/remoting/parser/LocalTCCRemotingParser.java 48.38% <25.00%> (-9.31%) ⬇️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 32.25% <50.00%> (ø)
...in/java/io/seata/rm/tcc/remoting/RemotingDesc.java 65.21% <100.00%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
... and 4 more

@yujianfei1986 yujianfei1986 changed the title feature:TCC mode supports tcc annotation marked on both interface and implimentation class feature:TCC mode supports tcc annotation marked on both interface and implementation class Mar 25, 2022
@wangliang181230 wangliang181230 changed the title feature:TCC mode supports tcc annotation marked on both interface and implementation class feature: TCC mode supports tcc annotation marked on both interface and implementation class Mar 25, 2022
wangliang181230
wangliang181230 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the module/tcc tcc module label Apr 3, 2022
@yujianfei1986 yujianfei1986 reopened this Apr 6, 2022
@wangliang181230 wangliang181230 added this to the 2.0.0 milestone Jun 30, 2022
@funky-eyes funky-eyes modified the milestones: 2.0.0, 1.6.0 Aug 15, 2022
funky-eyes
funky-eyes approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the type: feature Category issues or prs related to feature request. label Aug 17, 2022
@funky-eyes funky-eyes merged commit e3af78e into apache:develop Aug 17, 2022
slievrly
slievrly reviewed Aug 20, 2022
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

misselvexu pushed a commit to misselvexu/seata that referenced this pull request Aug 23, 2022
@yujianfei1986 @misselvexu
feature: TCC mode supports tcc annotation marked on both interface an…
f388d0f 
…d implementation class (apache#4479)
@funky-eyes
Copy link
Contributor

麻烦请签署Seata社区cla协议：https://cla-assistant.io/seata/seata?pullRequest=5164

@PeppaO PeppaO mentioned this pull request Mar 23, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@wangliang181230 wangliang181230 wangliang181230 approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

@objcoding objcoding Awaiting requested review from objcoding

Assignees
No one assigned
Labels
module/tcc tcc module type: feature Category issues or prs related to feature request.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yujianfei1986 @codecov-commenter @funky-eyes @wangliang181230 @slievrly