Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove Pagination hideOnlyOnePage attribute #4487

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

liuqiufeng
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Pagination组件的hideOnlyOnePage属性(当分页数为1时,是否隐藏分页器)会在当前页数据不足一页时无法显示,导致无法翻页,故移除此属性。组件详情:http://xconsole.cloud/cloudbench/component/nrh3g6

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #4487 (96811ec) into develop (99fc37d) will increase coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4487      +/-   ##
=============================================
+ Coverage      48.96%   49.29%   +0.32%     
- Complexity      4030     4044      +14     
=============================================
  Files            731      731              
  Lines          25323    25330       +7     
  Branches        3137     3136       -1     
=============================================
+ Hits           12399    12486      +87     
+ Misses         11596    11519      -77     
+ Partials        1328     1325       -3     
Impacted Files Coverage Δ
...ava/io/seata/common/util/LowerCaseLinkHashMap.java 0.00% <0.00%> (ø)
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 83.33% <ø> (ø)
...source/AbstractDataSourceCacheResourceManager.java 42.85% <0.00%> (-42.86%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
.../main/java/io/seata/rm/BaseDataSourceResource.java 31.14% <0.00%> (-3.28%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 55.39% <0.00%> (-0.72%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️
...r/console/impl/file/GlobalLockFileServiceImpl.java 97.43% <0.00%> (+2.56%) ⬆️
...o/seata/server/session/AbstractSessionManager.java 61.19% <0.00%> (+2.98%) ⬆️
...torage/file/store/FileTransactionStoreManager.java 60.96% <0.00%> (+4.19%) ⬆️
... and 2 more

@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 25, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/console labels Mar 25, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 22aad71 into apache:develop Mar 28, 2022
@liuqiufeng liuqiufeng deleted the pagination_bugfix branch March 29, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/console type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants