Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the exception with SeataTCCFenceAutoConfiguration #4515

Merged
merged 9 commits into from
Jun 6, 2022

Conversation

pengten
Copy link
Contributor

@pengten pengten commented Mar 31, 2022

fix the ClassNotFoundException with SeataTCCFenceAutoConfiguration when jdbc unused.

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复SeataTCCFenceAutoConfiguration在客户端未使用DB时,启动抛出ClassNotFoundException的问题。

Ⅱ. Does this pull request fix one issue?

fixes #4514

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #4515 (c7f4edc) into develop (8ac7503) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4515      +/-   ##
=============================================
+ Coverage      48.45%   48.62%   +0.17%     
- Complexity      4022     4041      +19     
=============================================
  Files            734      734              
  Lines          25577    25577              
  Branches        3156     3156              
=============================================
+ Hits           12393    12438      +45     
+ Misses         11849    11803      -46     
- Partials        1335     1336       +1     
Impacted Files Coverage Δ
.../autoconfigure/SeataTCCFenceAutoConfiguration.java 0.00% <ø> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 44.48% <0.00%> (-0.41%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 67.63% <0.00%> (+3.75%) ⬆️
...java/io/seata/server/storage/SessionConverter.java 89.09% <0.00%> (+9.09%) ⬆️
...va/io/seata/server/console/vo/GlobalSessionVO.java 55.88% <0.00%> (+33.82%) ⬆️

@slievrly slievrly added the module/tcc tcc module label Apr 3, 2022
@clverhack
Copy link

这个问题再1.5.1 里面解决了吗

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Pls remove change log into 1.5.2.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 同上

@pengten pengten changed the title bugfix: fix the error of SeataTCCFenceAutoConfiguration when database… bugfix: fix the exception with SeataTCCFenceAutoConfiguration Jun 6, 2022
@slievrly slievrly merged commit a43beb4 into apache:develop Jun 6, 2022
@slievrly slievrly added this to the 1.5.2 milestone Jun 6, 2022
liuqiufeng pushed a commit to liuqiufeng/seata that referenced this pull request Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/tcc tcc module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SeataTCCFenceAutoConfiguration throws error when database is not in use
5 participants