Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize : enhance fail/timeout status metric and log level #4517

Merged
merged 9 commits into from
Apr 6, 2022

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Mar 31, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. 对fail做了summary和timer上报
  2. 对2阶段timeout做了summary上报(不需要timer,因为超时都是一个时间)
  3. fix defaultcoodinator的日志级别

Ⅱ. Does this pull request fix one issue?

#4516

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Bughue Bughue changed the title optimized : abnormal status metric enhance optimized : enhance fail/timeout status metric and log level Apr 2, 2022
@Bughue Bughue changed the title optimized : enhance fail/timeout status metric and log level optimize : enhance fail/timeout status metric and log level Apr 2, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.5.0 milestone Apr 3, 2022
@slievrly
Copy link
Member

slievrly commented Apr 3, 2022

@Bughue add commit log in change/1.5.0 zh-cn/en

@slievrly slievrly added the module/metrics metrics module label Apr 3, 2022
@Bughue
Copy link
Contributor Author

Bughue commented Apr 6, 2022

@Bughue add commit log in change/1.5.0 zh-cn/en

ok

@slievrly slievrly merged commit 660166a into apache:develop Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/metrics metrics module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants