bugfix: fix rollback event repeated and some event status not correct #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bughue
changed the title
Bughue
changed the title
funky-eyes
reviewed
Apr 8, 2022
server/src/main/java/io/seata/server/session/SessionHelper.java
Outdated
Show resolved
Hide resolved
…_timeout_not_remove
…_remove � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java � server/src/main/java/io/seata/server/session/SessionHelper.java
Bughue
changed the title
…_remove � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java
funky-eyes
added
type: bug
…_remove � Conflicts: � server/src/main/java/io/seata/server/session/SessionHelper.java
Codecov Report
@@ Coverage Diff @@
## develop #4533 +/- ##
=============================================
- Coverage 49.06% 49.03% -0.04%
+ Complexity 4093 4089 -4
=============================================
Files 733 733
Lines 26005 26012 +7
Branches 3212 3213 +1
=============================================
- Hits 12760 12755 -5
- Misses 11886 11895 +9
- Partials 1359 1362 +3
|
slievrly
reviewed
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
解决#4531 提到的问题
1 是handleRetryCommitting超时后直接发了event，但没有endCommit
---- 改造成endCommitFail
---- （#4551 改造之后仍然有这个问题）
2 是endRollbackFailed自带了postTcSessionEndEvent()，下面还再发一次，事件重复了
----去掉外层的event，保留新方法里面的event
---- （#4551 改造之后仍然有这个问题，但发的是两个不同状态的event）
commit的处理同理
Ⅱ. Does this pull request fix one issue?
fixes #4531
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews