Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix test case fail #4535

Merged
merged 5 commits into from
Apr 9, 2022
Merged

bugfix: fix test case fail #4535

merged 5 commits into from
Apr 9, 2022

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title bugfix: fix test case fail [wip]bugfix: fix test case fail Apr 8, 2022
@funky-eyes funky-eyes added the Do Not Merge Do not merge into develop label Apr 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #4535 (e2a8a96) into develop (abe196f) will increase coverage by 0.10%.
The diff coverage is 52.34%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4535      +/-   ##
=============================================
+ Coverage      49.27%   49.37%   +0.10%     
- Complexity      4068     4076       +8     
=============================================
  Files            731      731              
  Lines          25370    25465      +95     
  Branches        3146     3156      +10     
=============================================
+ Hits           12501    12574      +73     
- Misses         11539    11556      +17     
- Partials        1330     1335       +5     
Impacted Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...n/src/main/java/io/seata/common/DefaultValues.java 0.00% <ø> (ø)
...c/main/java/io/seata/core/context/RootContext.java 46.77% <0.00%> (-2.38%) ⬇️
...e/protocol/transaction/BranchRegisterResponse.java 86.66% <ø> (ø)
...ta/core/rpc/netty/AbstractNettyRemotingClient.java 18.62% <ø> (ø)
...a/io/seata/rm/datasource/xa/ResourceManagerXA.java 14.54% <12.50%> (+0.25%) ⬆️
.../java/io/seata/server/coordinator/DefaultCore.java 53.61% <16.66%> (-2.88%) ⬇️
.../autoconfigure/properties/client/RmProperties.java 39.62% <25.00%> (-2.60%) ⬇️
...oconfigure/properties/server/ServerProperties.java 28.57% <25.00%> (-0.60%) ⬇️
.../main/java/io/seata/rm/BaseDataSourceResource.java 30.64% <50.00%> (-3.79%) ⬇️
... and 15 more

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module and removed Do Not Merge Do not merge into develop labels Apr 9, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Apr 9, 2022
@funky-eyes funky-eyes changed the title [wip]bugfix: fix test case fail bugfix: fix test case fail Apr 9, 2022
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 53d65bf into apache:develop Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants