Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: support oracle nclob types #4543

Merged
merged 70 commits into from Sep 6, 2022

Conversation

doubleDimple
Copy link
Contributor

@doubleDimple doubleDimple commented Apr 10, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

解决AT模式下oracle不支持NCLOB

Ⅱ. Does this pull request fix one issue?

fixes #4537

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

doubleDimple and others added 30 commits January 3, 2022 15:01
# Conflicts:
#	core/src/main/java/io/seata/core/console/result/PageResult.java
#	server/src/main/java/io/seata/server/storage/SessionConverter.java
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2022

Codecov Report

Merging #4543 (c081364) into develop (8ec5ccd) will increase coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4543      +/-   ##
=============================================
+ Coverage      49.03%   49.20%   +0.17%     
- Complexity      4087     4107      +20     
=============================================
  Files            736      736              
  Lines          25784    25784              
  Branches        3180     3180              
=============================================
+ Hits           12642    12686      +44     
+ Misses         11799    11754      -45     
- Partials        1343     1344       +1     
Impacted Files Coverage Δ
...seata/rm/datasource/undo/AbstractUndoExecutor.java 69.01% <0.00%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 65.72% <0.00%> (+2.54%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️
...java/io/seata/server/storage/SessionConverter.java 89.09% <0.00%> (+9.09%) ⬆️
...va/io/seata/server/console/vo/GlobalSessionVO.java 55.88% <0.00%> (+33.82%) ⬆️

@doubleDimple doubleDimple changed the title [WIP]optimize: support oracle binary types 4537 [WIP]optimize: support oracle binary types Apr 10, 2022
@doubleDimple doubleDimple changed the title [WIP]optimize: support oracle binary types optimize: support oracle binary types Apr 18, 2022
@funky-eyes funky-eyes requested a review from jsbxyyx April 21, 2022 13:47
@slievrly
Copy link
Member

slievrly commented Sep 5, 2022

DB: oracle 19c

  1. insert SQL statement cannot be reproduced the problem.
  2. update SQL statement can reproduced the problem and the fixed code is validated to be effective.
public void nclobUpdateTest(){
        String sql = "update clob_test set name=? where id=1";
        jdbcTemplate.execute(sql, new PreparedStatementCallback<Object>() {
            @Override
            public Object doInPreparedStatement(PreparedStatement ps) throws SQLException, DataAccessException {
                String text="textYYY";
                Reader clobReader = new StringReader(text);
                ps.setCharacterStream(1,clobReader,text.length());
                return ps.executeUpdate();
            }
        });
    }

@slievrly
Copy link
Member

slievrly commented Sep 5, 2022

@slievrly slievrly changed the title optimize: support oracle binary types bugfix: support oracle nclob types Sep 5, 2022
@slievrly slievrly self-requested a review September 5, 2022 08:37
@slievrly slievrly added this to the 1.6.0 milestone Sep 5, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit b5ddb71 into apache:develop Sep 6, 2022
@slievrly slievrly added the module/rm-datasource rm-datasource module label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT mode oracle some binary datatypes not support
5 participants