Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix RetryRollbacking return NPE #4561

Merged
merged 8 commits into from
Apr 22, 2022
Merged

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Apr 21, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

allSessions/findGlobalSessions 都有可能返回null,不判断的话可能导致npe
现在发现两个方面有这个问题

  1. 批量处理session(retry)
  2. console相关的查询

Ⅱ. Does this pull request fix one issue?

fixes #4560

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #4561 (39417c5) into develop (496d08c) will increase coverage by 0.00%.
The diff coverage is 64.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4561   +/-   ##
==========================================
  Coverage      49.44%   49.45%           
- Complexity      4070     4072    +2     
==========================================
  Files            732      732           
  Lines          25517    25521    +4     
  Branches        3152     3153    +1     
==========================================
+ Hits           12618    12621    +3     
  Misses         11555    11555           
- Partials        1344     1345    +1     
Impacted Files Coverage Δ
...in/java/io/seata/server/session/SessionHelper.java 67.36% <0.00%> (-1.45%) ⬇️
...ver/storage/db/session/DataBaseSessionManager.java 36.84% <33.33%> (ø)
...rage/db/store/DataBaseTransactionStoreManager.java 61.44% <80.00%> (+2.40%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 54.09% <100.00%> (+0.37%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️

@funky-eyes funky-eyes added this to the 1.5.0 milestone Apr 21, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Apr 21, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
验证通过
LGTM

@funky-eyes funky-eyes mentioned this pull request Apr 22, 2022
1 task
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: fix allSessions/findGlobalSessions may return null and cause npe bugfix: fix RetryRollbacking return NPE Apr 22, 2022
@slievrly slievrly merged commit a05e5d9 into apache:develop Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle RetryRollbacking NPE
4 participants