-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix prepareUndoLogAll in MySQLInsertOrUpdateExecutor #4579
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4579 +/- ##
=============================================
- Coverage 49.43% 49.28% -0.15%
+ Complexity 4072 4056 -16
=============================================
Files 732 732
Lines 25529 25529
Branches 3153 3153
=============================================
- Hits 12621 12583 -38
- Misses 11563 11603 +40
+ Partials 1345 1343 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xjlgod Pls fix some typos in MySQLInsertOrUpdateExecutor L144. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have done it. |
Ⅰ. Describe what this PR did
Put prepareUndoLogAll in right position
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews