Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix prepareUndoLogAll in MySQLInsertOrUpdateExecutor #4579

Merged
merged 1 commit into from
May 3, 2022
Merged

bugfix: fix prepareUndoLogAll in MySQLInsertOrUpdateExecutor #4579

merged 1 commit into from
May 3, 2022

Conversation

xjlgod
Copy link
Contributor

@xjlgod xjlgod commented May 1, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Put prepareUndoLogAll in right position

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xjlgod xjlgod changed the title Fix prepareUndoLogAll in MySQLInsertOrUpdateExecutor bugfix: fix prepareUndoLogAll in MySQLInsertOrUpdateExecutor May 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #4579 (d15c560) into develop (d4ce0a5) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

❗ Current head d15c560 differs from pull request most recent head 693564a. Consider uploading reports for the commit 693564a to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4579      +/-   ##
=============================================
- Coverage      49.43%   49.28%   -0.15%     
+ Complexity      4072     4056      -16     
=============================================
  Files            732      732              
  Lines          25529    25529              
  Branches        3153     3153              
=============================================
- Hits           12621    12583      -38     
- Misses         11563    11603      +40     
+ Partials        1345     1343       -2     
Impacted Files Coverage Δ
...source/exec/mysql/MySQLInsertOrUpdateExecutor.java 31.07% <0.00%> (ø)
...va/io/seata/server/console/vo/GlobalSessionVO.java 22.05% <0.00%> (-33.83%) ⬇️
...java/io/seata/server/storage/SessionConverter.java 80.00% <0.00%> (-9.10%) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 48.79% <0.00%> (-4.82%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 63.87% <0.00%> (-2.61%) ⬇️
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 12.98% <0.00%> (-1.30%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 81.00% <0.00%> (-1.17%) ⬇️
...tasource/sql/struct/cache/MysqlTableMetaCache.java 78.88% <0.00%> (-1.12%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 54.09% <0.00%> (ø)
...in/java/io/seata/server/session/SessionHelper.java 68.42% <0.00%> (+1.05%) ⬆️
... and 4 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone May 1, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: AT AT transaction mode module/rm-datasource rm-datasource module labels May 1, 2022
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

slievrly commented May 1, 2022

@xjlgod Pls fix some typos in MySQLInsertOrUpdateExecutor L144.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xjlgod
Copy link
Contributor Author

xjlgod commented May 1, 2022

@xjlgod Pls fix some typos in MySQLInsertOrUpdateExecutor L144.

I have done it.

@caohdgege caohdgege merged commit 8c350b0 into apache:develop May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: AT AT transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants