Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix bug on skipping lock check #4607

Merged
merged 10 commits into from Jun 16, 2022
Merged

bugfix: fix bug on skipping lock check #4607

merged 10 commits into from Jun 16, 2022

Conversation

tuwenlin
Copy link
Contributor

The method ConnectionContext.allBeforeImageEmpty()
when "null == undoLog.getBeforeImage()" should continue the loop

@tuwenlin tuwenlin changed the title bugfix:when beforeImage==null should return true bugfix:when beforeImage==null should continue the loop May 13, 2022
@tuwenlin tuwenlin changed the title bugfix:when beforeImage==null should continue the loop bugfix:fix bug on skipping lock check May 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #4607 (ff453fa) into develop (f51a069) will increase coverage by 0.67%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4607      +/-   ##
=============================================
+ Coverage      48.61%   49.28%   +0.67%     
- Complexity      4055     4087      +32     
=============================================
  Files            735      735              
  Lines          25616    25616              
  Branches        3163     3162       -1     
=============================================
+ Hits           12454    12626     +172     
+ Misses         11825    11642     -183     
- Partials        1337     1348      +11     
Impacted Files Coverage Δ
...java/io/seata/rm/datasource/ConnectionContext.java 75.21% <50.00%> (+0.85%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 65.72% <0.00%> (-1.14%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 81.00% <0.00%> (+0.38%) ⬆️
...in/java/io/seata/server/session/SessionHelper.java 66.66% <0.00%> (+1.04%) ⬆️
...tasource/sql/struct/cache/MysqlTableMetaCache.java 80.00% <0.00%> (+1.11%) ⬆️
.../java/io/seata/server/coordinator/DefaultCore.java 48.79% <0.00%> (+3.01%) ⬆️
.../main/java/io/seata/rm/BaseDataSourceResource.java 30.64% <0.00%> (+3.22%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 47.75% <0.00%> (+3.26%) ⬆️
... and 5 more

@pengten
Copy link
Contributor

pengten commented May 17, 2022

这些bugfix是不是应该合并到1.5.1去,基于1.5.0开发

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 登记pr至2.0的md上

@funky-eyes funky-eyes added this to the 2.0.0 milestone May 17, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels May 17, 2022
@tuwenlin
Copy link
Contributor Author

LGTM 登记pr至2.0的md上

已登记

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly modified the milestones: 2.0.0, 1.5.2 Jun 14, 2022
# Conflicts:
#	changes/2.0.0.md
#	changes/en-us/2.0.0.md
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix:fix bug on skipping lock check bugfix: fix bug on skipping lock check Jun 16, 2022
@slievrly slievrly merged commit e007fa5 into apache:develop Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants