New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the sql exception when pk is str #4653
bugfix: fix the sql exception when pk is str #4653
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4653 +/- ##
=============================================
- Coverage 48.66% 48.49% -0.18%
+ Complexity 4070 4049 -21
=============================================
Files 736 736
Lines 25643 25646 +3
Branches 3163 3165 +2
=============================================
- Hits 12480 12436 -44
- Misses 11825 11873 +48
+ Partials 1338 1337 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KPI products, hope to deal with empty lines |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews