Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the sql exception when pk is str #4653

Merged
merged 10 commits into from Jul 8, 2022

Conversation

caohdgege
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. fix the sql exception when pk is str
  2. fix typo

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #4653 (0226187) into develop (dd7a729) will decrease coverage by 0.17%.
The diff coverage is 40.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4653      +/-   ##
=============================================
- Coverage      48.66%   48.49%   -0.18%     
+ Complexity      4070     4049      -21     
=============================================
  Files            736      736              
  Lines          25643    25646       +3     
  Branches        3163     3165       +2     
=============================================
- Hits           12480    12436      -44     
- Misses         11825    11873      +48     
+ Partials        1338     1337       -1     
Impacted Files Coverage Δ
...source/exec/mysql/MySQLInsertOrUpdateExecutor.java 30.55% <40.00%> (-0.52%) ⬇️
...va/io/seata/server/console/vo/GlobalSessionVO.java 22.05% <0.00%> (-33.83%) ⬇️
...java/io/seata/server/storage/SessionConverter.java 80.00% <0.00%> (-9.10%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 63.17% <0.00%> (-3.69%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 44.89% <0.00%> (-0.41%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (+0.64%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Jun 15, 2022
@funky-eyes funky-eyes added this to the 1.5.2 milestone Jun 15, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 708f97f into apache:develop Jul 8, 2022
@365code365
Copy link

KPI products, hope to deal with empty lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants