Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize the console navigation bar #4693

Merged
merged 4 commits into from Jun 14, 2022

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jun 14, 2022

Signed-off-by: slievrly slievrly@163.com

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize the console navigation bar

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #4693 (c6e4d33) into develop (120a940) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4693   +/-   ##
==========================================
  Coverage      48.60%   48.61%           
+ Complexity      4055     4054    -1     
==========================================
  Files            735      735           
  Lines          25616    25616           
  Branches        3163     3163           
==========================================
+ Hits           12451    12452    +1     
- Misses         11824    11826    +2     
+ Partials        1341     1338    -3     
Impacted Files Coverage Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (ø)
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (+0.64%) ⬆️

@slievrly slievrly merged commit f51a069 into apache:develop Jun 14, 2022
@slievrly slievrly added this to the 1.5.2 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants