Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: upgrade logback dependency to 1.2.9 #4728

Merged
merged 3 commits into from Jun 28, 2022
Merged

optimize: upgrade logback dependency to 1.2.9 #4728

merged 3 commits into from Jun 28, 2022

Conversation

Smery-lxm
Copy link
Contributor

@Smery-lxm Smery-lxm commented Jun 26, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4634

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title optimize:change logback version to 1.2.9 optimize: upgrade logback dependency to 1.2.9 Jun 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #4728 (0611bab) into develop (9baa6b4) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0611bab differs from pull request most recent head d41f734. Consider uploading reports for the commit d41f734 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4728   +/-   ##
==========================================
  Coverage      48.66%   48.67%           
- Complexity      4064     4065    +1     
==========================================
  Files            736      736           
  Lines          25635    25635           
  Branches        3162     3162           
==========================================
+ Hits           12476    12477    +1     
  Misses         11819    11819           
+ Partials        1340     1339    -1     
Impacted Files Coverage Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (+0.64%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why revert previous commit?

@Smery-lxm
Copy link
Contributor Author

why revert previous commit?

I clicked merge branch then I thought it may be a mistake T.T

@slievrly
Copy link
Member

why revert previous commit?

I clicked merge branch then I thought it may be a mistake T.T

keep the change only your want to modify in https://github.com/seata/seata/pull/4728/files

@Smery-lxm
Copy link
Contributor Author

why revert previous commit?

I clicked merge branch then I thought it may be a mistake T.T

keep the change only your want to modify in https://github.com/seata/seata/pull/4728/files

Ok. I used force-push to modify what I want to do

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 请在changes文件夹中的中英两版develop.md中登记pr和作者信息,参考已登记信息填写即可

@funky-eyes funky-eyes added this to the 1.5.2 milestone Jun 27, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit ff5ea93 into apache:develop Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logback-classic-1.2.0
4 participants