New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: upgrade logback dependency to 1.2.9 #4728
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4728 +/- ##
==========================================
Coverage 48.66% 48.67%
- Complexity 4064 4065 +1
==========================================
Files 736 736
Lines 25635 25635
Branches 3162 3162
==========================================
+ Hits 12476 12477 +1
Misses 11819 11819
+ Partials 1340 1339 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why revert previous commit?
I clicked merge branch then I thought it may be a mistake T.T |
keep the change only your want to modify in https://github.com/seata/seata/pull/4728/files |
Ok. I used force-push to modify what I want to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 请在changes文件夹中的中英两版develop.md中登记pr和作者信息,参考已登记信息填写即可
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #4634
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews