Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix UT failed in AsyncWorkerTest and LockManagerTest #4731

Merged
merged 2 commits into from Jun 29, 2022

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix UT failed in AsyncWorkerTest and LockManagerTest

Ⅱ. Does this pull request fix one issue?

fixes #4672 #4673

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.5.2 milestone Jun 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #4731 (36346ec) into develop (6bbc672) will decrease coverage by 0.17%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4731      +/-   ##
=============================================
- Coverage      48.66%   48.49%   -0.18%     
+ Complexity      4065     4049      -16     
=============================================
  Files            736      736              
  Lines          25635    25643       +8     
  Branches        3162     3163       +1     
=============================================
- Hits           12476    12436      -40     
- Misses         11820    11870      +50     
+ Partials        1339     1337       -2     
Impacted Files Coverage Δ
.../main/java/io/seata/rm/datasource/AsyncWorker.java 44.82% <57.14%> (+1.07%) ⬆️
...torage/file/store/FileTransactionStoreManager.java 56.27% <100.00%> (-0.51%) ⬇️
...va/io/seata/server/console/vo/GlobalSessionVO.java 22.05% <0.00%> (-33.83%) ⬇️
...java/io/seata/server/storage/SessionConverter.java 80.00% <0.00%> (-9.10%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 63.17% <0.00%> (-3.69%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 1cbb274 into apache:develop Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UT failed in AsyncWorkerTest
3 participants