Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: support mysql8 in release package #4745

Merged
merged 4 commits into from Jul 6, 2022

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jul 6, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

support mysql8 in release package

Ⅱ. Does this pull request fix one issue?

fix #4712

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #4745 (72b2637) into develop (1cbb274) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4745      +/-   ##
=============================================
- Coverage      48.67%   48.66%   -0.02%     
  Complexity      4068     4068              
=============================================
  Files            736      736              
  Lines          25643    25643              
  Branches        3163     3163              
=============================================
- Hits           12481    12478       -3     
- Misses         11823    11826       +3     
  Partials        1339     1339              
Impacted Files Coverage Δ
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (ø)
...erver/storage/file/session/FileSessionManager.java 49.68% <0.00%> (+0.63%) ⬆️

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit dd7a729 into apache:develop Jul 6, 2022
@slievrly slievrly added this to the 1.5.2 milestone Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.5.1版本里面没有mysql8.0的依赖
3 participants