Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add copyright notice #4800

Merged
merged 7 commits into from Jul 26, 2022
Merged

optimize: add copyright notice #4800

merged 7 commits into from Jul 26, 2022

Conversation

AlexStocks
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add apache notice

Ⅱ. Does this pull request fix one issue?

fixes #4799

@slievrly slievrly changed the title add apache notice optimize: add apache notice Jul 21, 2022
@slievrly slievrly changed the title optimize: add apache notice optimize: add copyright notice Jul 21, 2022
@slievrly slievrly added this to the 1.6.0 milestone Jul 21, 2022
@AlexStocks
Copy link
Contributor Author

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #4800 (3e1e3d1) into develop (b7dafbf) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4800      +/-   ##
=============================================
- Coverage      49.20%   49.20%   -0.01%     
+ Complexity      4091     4090       -1     
=============================================
  Files            736      736              
  Lines          25723    25723              
  Branches        3177     3177              
=============================================
- Hits           12658    12656       -2     
  Misses         11716    11716              
- Partials        1349     1351       +2     
Impacted Files Coverage Δ
...torage/file/store/FileTransactionStoreManager.java 55.62% <0.00%> (-0.65%) ⬇️
...erver/storage/file/session/FileSessionManager.java 47.77% <0.00%> (-0.64%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

@slievrly
Copy link
Member

Pls add change log in: https://github.com/seata/seata/blob/develop/changes/en-us/develop.md https://github.com/seata/seata/blob/develop/changes/zh-cn/develop.md

done

The change log should be moved to the optimize module in develop.md . bugfix represents a fix to transaction service.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @slievrly PTAL

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 15add9a into apache:develop Jul 26, 2022
conghuhu pushed a commit to conghuhu/seata that referenced this pull request Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the notice file is empty
4 participants