Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix metrics tags coverage in the seata-server side #4860

Merged
merged 11 commits into from Aug 19, 2022

Conversation

robynron
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复seata-server侧在发布metrics时,其tag覆盖的问题;
期望:每个拥有不同tags的metric,都能独立记录其度量,不会产生tag覆盖问题。

Ⅱ. Does this pull request fix one issue?

fixes #4859

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@robynron robynron changed the title [WIP] bugfix: fix metrics tags coverage in the seata-server side #4860 [WIP] bugfix: fix metrics tags coverage in the seata-server side Aug 11, 2022
@robynron robynron force-pushed the dev/seata-server_metrics_fix branch from e59edac to 392c44c Compare August 12, 2022 03:37
@robynron robynron changed the title [WIP] bugfix: fix metrics tags coverage in the seata-server side bugfix: fix metrics tags coverage in the seata-server side Aug 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #4860 (3d1c992) into develop (8ace7ab) will decrease coverage by 0.00%.
The diff coverage is 20.51%.

❗ Current head 3d1c992 differs from pull request most recent head d18e2ae. Consider uploading reports for the commit d18e2ae to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4860      +/-   ##
=============================================
- Coverage      49.17%   49.16%   -0.01%     
- Complexity      4091     4094       +3     
=============================================
  Files            737      737              
  Lines          25745    25750       +5     
  Branches        3180     3181       +1     
=============================================
  Hits           12660    12660              
+ Misses         11736    11735       -1     
- Partials        1349     1355       +6     
Impacted Files Coverage Δ
...n/java/io/seata/server/metrics/MetricsManager.java 76.92% <ø> (ø)
...java/io/seata/spring/tcc/TccActionInterceptor.java 14.00% <0.00%> (ø)
...va/io/seata/spring/tcc/TccAnnotationProcessor.java 0.00% <0.00%> (ø)
.../rm/tcc/remoting/parser/DefaultRemotingParser.java 23.80% <0.00%> (ø)
...ta/rm/tcc/remoting/parser/DubboRemotingParser.java 3.84% <0.00%> (ø)
...eata/rm/tcc/remoting/parser/HSFRemotingParser.java 7.69% <0.00%> (ø)
.../rm/tcc/remoting/parser/SofaRpcRemotingParser.java 4.54% <0.00%> (ø)
...rm/tcc/remoting/parser/LocalTCCRemotingParser.java 48.38% <25.00%> (-9.31%) ⬇️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 32.25% <50.00%> (ø)
...in/java/io/seata/rm/tcc/remoting/RemotingDesc.java 65.21% <100.00%> (ø)
... and 9 more

@robynron robynron force-pushed the dev/seata-server_metrics_fix branch from 3b8016f to 4fb7aa1 Compare August 17, 2022 12:43
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 9f71c37 into apache:develop Aug 19, 2022
misselvexu pushed a commit to misselvexu/seata that referenced this pull request Aug 23, 2022
@slievrly slievrly added this to the 1.6.0 milestone Sep 7, 2022
@slievrly slievrly added the module/metrics metrics module label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/metrics metrics module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bugfix: fix bug of seata-server's metric
3 participants