New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix metrics tags coverage in the seata-server side #4860
Merged
slievrly
merged 11 commits into
apache:develop
from
robynron:dev/seata-server_metrics_fix
Aug 19, 2022
Merged
bugfix: fix metrics tags coverage in the seata-server side #4860
slievrly
merged 11 commits into
apache:develop
from
robynron:dev/seata-server_metrics_fix
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robynron
changed the title
[WIP] bugfix: fix metrics tags coverage in the seata-server side #4860
[WIP] bugfix: fix metrics tags coverage in the seata-server side
Aug 11, 2022
robynron
force-pushed
the
dev/seata-server_metrics_fix
branch
from
August 12, 2022 03:37
e59edac
to
392c44c
Compare
slievrly
reviewed
Aug 15, 2022
robynron
changed the title
[WIP] bugfix: fix metrics tags coverage in the seata-server side
bugfix: fix metrics tags coverage in the seata-server side
Aug 15, 2022
Codecov Report
@@ Coverage Diff @@
## develop #4860 +/- ##
=============================================
- Coverage 49.17% 49.16% -0.01%
- Complexity 4091 4094 +3
=============================================
Files 737 737
Lines 25745 25750 +5
Branches 3180 3181 +1
=============================================
Hits 12660 12660
+ Misses 11736 11735 -1
- Partials 1349 1355 +6
|
slievrly
reviewed
Aug 17, 2022
server/src/test/java/io/seata/server/metrics/RegistryMeterKeyTest.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Aug 17, 2022
robynron
force-pushed
the
dev/seata-server_metrics_fix
branch
from
August 17, 2022 12:43
3b8016f
to
4fb7aa1
Compare
slievrly
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
修复seata-server侧在发布metrics时,其tag覆盖的问题;
期望:每个拥有不同tags的metric,都能独立记录其度量,不会产生tag覆盖问题。
Ⅱ. Does this pull request fix one issue?
fixes #4859
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews