Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix failed to get server recovery properties #4915

Merged
merged 4 commits into from Sep 7, 2022
Merged

optimize: fix failed to get server recovery properties #4915

merged 4 commits into from Sep 7, 2022

Conversation

tuwenlin
Copy link
Contributor

@tuwenlin tuwenlin commented Sep 7, 2022

fix:#4900

@slievrly slievrly added the module/server server module label Sep 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #4915 (5fb09a0) into develop (c384cc7) will decrease coverage by 0.00%.
The diff coverage is 53.33%.

❗ Current head 5fb09a0 differs from pull request most recent head 8aa7e12. Consider uploading reports for the commit 8aa7e12 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4915      +/-   ##
=============================================
- Coverage      49.04%   49.03%   -0.01%     
- Complexity      4088     4090       +2     
=============================================
  Files            736      736              
  Lines          25786    25798      +12     
  Branches        3180     3180              
=============================================
+ Hits           12646    12651       +5     
- Misses         11799    11805       +6     
- Partials        1341     1342       +1     
Impacted Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 47.75% <ø> (ø)
...re/properties/server/ServerRecoveryProperties.java 52.94% <53.33%> (-7.06%) ⬇️
...erver/storage/file/session/FileSessionManager.java 53.50% <0.00%> (-0.64%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (ø)

@funky-eyes funky-eyes added the type: bug Category issues or prs related to bug. label Sep 7, 2022
@funky-eyes funky-eyes added this to the 1.6.0 milestone Sep 7, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix:fix failed to get server recovery properties optimize: fix failed to get server recovery properties Sep 7, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 6c739ce into apache:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants