Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix some vulnerabilities in console and upgrade skywalking-eyes #4921

Merged
merged 4 commits into from Sep 8, 2022

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 8, 2022

Signed-off-by: slievrly slievrly@163.com

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix some vulnerabilities in console and upgrade skywalking-eyes

  1. fix some vulnerabilities in console package.json
  2. upgrade skywalking-eyes to solve optional dependencies Fix optional dependencies are not excluded skywalking-eyes#136 (comment)

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

npm install
npm start

image

Ⅴ. Special notes for reviews

…eyes

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly added this to the 1.6.0 milestone Sep 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4921 (e327334) into develop (6c739ce) will increase coverage by 0.17%.
The diff coverage is n/a.

❗ Current head e327334 differs from pull request most recent head 7ab6ff5. Consider uploading reports for the commit 7ab6ff5 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4921      +/-   ##
=============================================
+ Coverage      49.04%   49.21%   +0.17%     
- Complexity      4091     4112      +21     
=============================================
  Files            736      736              
  Lines          25798    25798              
  Branches        3180     3180              
=============================================
+ Hits           12652    12697      +45     
+ Misses         11805    11760      -45     
  Partials        1341     1341              
Impacted Files Coverage Δ
...rage/redis/store/RedisTransactionStoreManager.java 66.57% <0.00%> (+3.39%) ⬆️
...java/io/seata/server/storage/SessionConverter.java 89.09% <0.00%> (+9.09%) ⬆️
...va/io/seata/server/console/vo/GlobalSessionVO.java 55.88% <0.00%> (+33.82%) ⬆️

@slievrly
Copy link
Member Author

slievrly commented Sep 8, 2022

image

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit ed308dd into apache:develop Sep 8, 2022
@slievrly slievrly moved this from Process to Finished in license governance Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants