Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix : fix rpcContext.getClientRMHolderMap() npe #4928

Merged
merged 62 commits into from Sep 13, 2022

Conversation

doubleDimple
Copy link
Contributor

@doubleDimple doubleDimple commented Sep 11, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4929

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

doubleDimple and others added 30 commits January 3, 2022 15:01
# Conflicts:
#	core/src/main/java/io/seata/core/console/result/PageResult.java
#	server/src/main/java/io/seata/server/storage/SessionConverter.java
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #4928 (1200ebe) into develop (247cf21) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4928   +/-   ##
==========================================
  Coverage      49.04%   49.04%           
- Complexity      4089     4091    +2     
==========================================
  Files            736      736           
  Lines          25798    25800    +2     
  Branches        3180     3181    +1     
==========================================
+ Hits           12652    12654    +2     
- Misses         11804    11805    +1     
+ Partials        1342     1341    -1     
Impacted Files Coverage Δ
...n/java/io/seata/core/rpc/netty/ChannelManager.java 0.00% <0.00%> (ø)
...erver/storage/file/session/FileSessionManager.java 54.14% <0.00%> (+0.63%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

@doubleDimple add changes in develop.md .

@funky-eyes funky-eyes added this to the 1.6.0 milestone Sep 13, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Sep 13, 2022
@funky-eyes funky-eyes merged commit bdb54a0 into apache:develop Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpcContext.getClientRMHolderMap() npe
5 participants