New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: output expression incorrectly throws npe #4954
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4954 +/- ##
=============================================
- Coverage 49.02% 49.02% -0.01%
- Complexity 4091 4092 +1
=============================================
Files 736 736
Lines 25818 25818
Branches 3184 3184
=============================================
- Hits 12657 12656 -1
- Misses 11815 11816 +1
Partials 1346 1346
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请在 https://github.com/seata/seata/tree/develop/changes 的中英两版develop.md进行此pr的登记,可参照其它人的登记方式,将pr和作者信息进行登记
已经登记 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
md文件里,贡献者名单里加一下自己的名字吧。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
output 表达式错误时,抛出期望的异常。而不是空指针
Ⅱ. Does this pull request fix one issue?
fixes #4948
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews