Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: output expression incorrectly throws npe #4954

Merged
merged 3 commits into from Sep 28, 2022

Conversation

1181954449
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

output 表达式错误时,抛出期望的异常。而不是空指针

Ⅱ. Does this pull request fix one issue?

fixes #4948

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2022

Codecov Report

Merging #4954 (1cbcb9a) into develop (0cdaa08) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4954      +/-   ##
=============================================
- Coverage      49.02%   49.02%   -0.01%     
- Complexity      4091     4092       +1     
=============================================
  Files            736      736              
  Lines          25818    25818              
  Branches        3184     3184              
=============================================
- Hits           12657    12656       -1     
- Misses         11815    11816       +1     
  Partials        1346     1346              
Impacted Files Coverage Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️

@funky-eyes funky-eyes changed the title [bugfix]解决output表达式错误时。保存执行结果空指针异常错误 bugfix: output expression incorrectly throws npe Sep 24, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请在 https://github.com/seata/seata/tree/develop/changes 的中英两版develop.md进行此pr的登记,可参照其它人的登记方式,将pr和作者信息进行登记

@1181954449
Copy link
Contributor Author

已经登记

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: SAGA SAGA transaction mode module/saga saga module labels Sep 28, 2022
@wangliang181230
Copy link
Contributor

md文件里,贡献者名单里加一下自己的名字吧。

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: SAGA SAGA transaction mode module/saga saga module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saga模式定义ServiceTask的Output表达式错误的话,会出现空指针异常
5 participants