optimize: do not execute triggerAfterCommit() in case of timeout #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/src/main/java/io/seata/server/console/impl/file/GlobalSessionFileServiceImpl.java
Codecov Report
@@ Coverage Diff @@
## develop #4958 +/- ##
=============================================
- Coverage 48.77% 48.76% -0.01%
Complexity 4078 4078
=============================================
Files 734 734
Lines 25855 25855
Branches 3190 3190
=============================================
- Hits 12610 12609 -1
Misses 11902 11902
- Partials 1343 1344 +1
|
|
马上改好，话说 https://github.com/seata/seata/pull/4445/files 这个PR也忘记登记了怎么办，要不要重新在这个PR里补一下 |
go ahead. |
miaoxueyu
changed the title
slievrly
reviewed
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
direct use of TransactionManager.commit () whether do check is timeout
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews