bugfix: fix undo_log id repeat #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release 0.5.2
Release 0.6.1
release 0.7.1
release 0.8.0
[release] release 1.0.0
release 1.2.0
[release]: release for 1.4.0
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
release: release 1.5.0
Signed-off-by: slievrly <slievrly@163.com>
release: release for 1.5.2
funky-eyes
requested changes
Oct 10, 2022
| @@ -91,6 +91,9 @@ private String buildBeforeImageSQL(TableMeta tableMeta, ArrayList<List<Object>> | |||
| suffix.append(" FOR UPDATE"); | |||
| StringJoiner selectSQLJoin = new StringJoiner(", ", prefix.toString(), suffix.toString()); | |||
| if (ONLY_CARE_UPDATE_COLUMNS) { | |||
| for (String updateColumn : updateColumns) { | |||
There was a problem hiding this comment.
Why not handle it in SQLUpdateRecognizer#getUpdateColumns
rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java
Outdated
Show resolved
Hide resolved
funky-eyes
added
type: bug
Codecov Report
@@ Coverage Diff @@
## develop #4985 +/- ##
=============================================
- Coverage 48.77% 48.58% -0.20%
+ Complexity 4078 4045 -33
=============================================
Files 734 732 -2
Lines 25855 25773 -82
Branches 3190 3173 -17
=============================================
- Hits 12610 12521 -89
- Misses 11901 11916 +15
+ Partials 1344 1336 -8
|
funky-eyes
reviewed
Oct 11, 2022
sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/SQLInsertRecognizer.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix undo_log id repeat
Ⅱ. Does this pull request fix one issue?
#4949
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews