Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove @EnableConfigurationProperties({SagaAsyncThreadPoolProperties.class}) #5038

Merged
merged 3 commits into from Nov 1, 2022

Conversation

crazy-sheep
Copy link
Contributor

@crazy-sheep crazy-sheep commented Oct 31, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

删除SagaAsyncThreadPoolExecutorConfiguration类上的@EnableConfigurationProperties({SagaAsyncThreadPoolProperties.class})注解。

Ⅱ. Does this pull request fix one issue?

fixes ##5020

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title seata-spring-boot-starter1.5.2版本saga模式开启异步调用启动报错 #5020 bugfix: remove @EnableConfigurationProperties({SagaAsyncThreadPoolProperties.class}) Nov 1, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.6.0 milestone Nov 1, 2022
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230
Copy link
Contributor

wangliang181230 commented Nov 1, 2022

多余的import移除一下。

Error:  io/seata/spring/boot/autoconfigure/SeataSagaAutoConfiguration.java:39:8: 
        Unused import - org.springframework.boot.context.properties.EnableConfigurationProperties. [UnusedImports]

@wangliang181230 wangliang181230 changed the title bugfix: remove @EnableConfigurationProperties({SagaAsyncThreadPoolProperties.class}) bugfix: remove @EnableConfigurationProperties({SagaAsyncThreadPoolProperties.class}) Nov 1, 2022
@funky-eyes
Copy link
Contributor

https://github.com/seata/seata/tree/develop/changes 将作者信息和pr信息登记至其中2个文件夹的develop.md中

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/seata-spring-boot-starter seata-spring-boot-starter module first-time contributor first-time contributor labels Nov 1, 2022
@funky-eyes funky-eyes merged commit 810c304 into apache:develop Nov 1, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/seata-spring-boot-starter seata-spring-boot-starter module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants