Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:unify the format of configuration items in yml files #5120

Merged
merged 12 commits into from
Dec 21, 2022

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Dec 3, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5117

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Merging #5120 (b711807) into develop (0827ee5) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5120      +/-   ##
=============================================
- Coverage      48.52%   48.47%   -0.05%     
  Complexity      4137     4137              
=============================================
  Files            743      743              
  Lines          26544    26517      -27     
  Branches        3294     3294              
=============================================
- Hits           12880    12854      -26     
- Misses         12263    12265       +2     
+ Partials        1401     1398       -3     
Impacted Files Coverage Δ
...gure/properties/config/ConfigApolloProperties.java 71.42% <ø> (-1.30%) ⬇️
...gure/properties/config/ConfigConsulProperties.java 72.72% <ø> (-2.28%) ⬇️
...gure/properties/config/ConfigCustomProperties.java 75.00% <ø> (-5.00%) ⬇️
...igure/properties/config/ConfigNacosProperties.java 50.00% <ø> (-8.34%) ⬇️
...e/properties/config/ConfigZooKeeperProperties.java 72.72% <ø> (-2.28%) ⬇️
.../properties/registry/RegistryConsulProperties.java 41.66% <ø> (-4.49%) ⬇️
.../properties/registry/RegistryCustomProperties.java 50.00% <ø> (-10.00%) ⬇️
...e/properties/registry/RegistryNacosProperties.java 31.57% <ø> (-10.65%) ⬇️
...e/properties/registry/RegistryRedisProperties.java 50.00% <ø> (-2.39%) ⬇️
...operties/registry/RegistryZooKeeperProperties.java 39.13% <ø> (-4.87%) ⬇️
... and 4 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@xingfudeshi xingfudeshi merged commit 8000195 into apache:develop Dec 21, 2022
@slievrly slievrly added this to the 1.6.1 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some parameters are not uniform
5 participants