Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix ClassNotFoundException caused when server starts when using Eureka #5179

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

xssdpgy
Copy link
Contributor

@xssdpgy xssdpgy commented Dec 21, 2022

bugfix: fix issue#5174 , when seata.registry.type is eureka, ClassNotFoundException is reported after seata-server startup

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

bugfix: fix issue#5174 , when seata.registry.type is eureka, ClassNotFoundException is reported after seata-server startup

Ⅱ. Does this pull request fix one issue?

fixes #5174

Ⅲ. Why don't you add test cases (unit test/integration test)?

When seata.registry.type is eureka, you can update pom.xml , then start seata-server for verify.

Ⅳ. Describe how to verify it

update pom.xml ,then start seata-server for verify it

Ⅴ. Special notes for reviews

bugfix: fix issue#5174 , when seata.registry.type is eureka, ClassNotFoundException is reported after seata-server startup
@CLAassistant
Copy link

CLAassistant commented Dec 21, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@8000195). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5179   +/-   ##
==========================================
  Coverage           ?   48.45%           
  Complexity         ?     4135           
==========================================
  Files              ?      743           
  Lines              ?    26517           
  Branches           ?     3294           
==========================================
  Hits               ?    12848           
  Misses             ?    12270           
  Partials           ?     1399           

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi changed the title bugfix: fix issue#5174 , when seata.registry.type is eureka, ClassNotFoundException is reported after seata-server startup bugfix: fix ClassNotFoundException caused when server starts when using Eureka Dec 21, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. first-time contributor first-time contributor labels Dec 21, 2022
@funky-eyes funky-eyes added this to the 1.6.1 milestone Dec 21, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 23f16e3 into apache:develop Dec 21, 2022
@slievrly
Copy link
Member

@xssdpgy thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seata1.6.0,注册中心为eureka时,seata服务端启动后报错NoClassDefFoundError
6 participants