-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix ClassNotFoundException caused when server starts when using Eureka #5179
Conversation
bugfix: fix issue#5174 , when seata.registry.type is eureka, ClassNotFoundException is reported after seata-server startup
Codecov Report
@@ Coverage Diff @@
## develop #5179 +/- ##
==========================================
Coverage ? 48.45%
Complexity ? 4135
==========================================
Files ? 743
Lines ? 26517
Branches ? 3294
==========================================
Hits ? 12848
Misses ? 12270
Partials ? 1399 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xssdpgy thanks for your contribution. |
bugfix: fix issue#5174 , when seata.registry.type is eureka, ClassNotFoundException is reported after seata-server startup
Ⅰ. Describe what this PR did
bugfix: fix issue#5174 , when seata.registry.type is eureka, ClassNotFoundException is reported after seata-server startup
Ⅱ. Does this pull request fix one issue?
fixes #5174
Ⅲ. Why don't you add test cases (unit test/integration test)?
When seata.registry.type is eureka, you can update pom.xml , then start seata-server for verify.
Ⅳ. Describe how to verify it
update pom.xml ,then start seata-server for verify it
Ⅴ. Special notes for reviews