-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: declare @Bean methods as static #5180
optimize: declare @Bean methods as static #5180
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5180 +/- ##
=============================================
- Coverage 48.47% 48.46% -0.01%
- Complexity 4136 4137 +1
=============================================
Files 743 743
Lines 26517 26517
Branches 3294 3294
=============================================
- Hits 12853 12851 -2
- Misses 12263 12271 +8
+ Partials 1401 1395 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
GlobalTransactionScanner,SeataAutoDataSourceProxyCreator declare @bean methods as static
Ⅱ. Does this pull request fix one issue?
#5176