Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: declare @Bean methods as static #5180

Merged

Conversation

whxxxxx
Copy link
Contributor

@whxxxxx whxxxxx commented Dec 21, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

GlobalTransactionScanner,SeataAutoDataSourceProxyCreator declare @bean methods as static

Ⅱ. Does this pull request fix one issue?

#5176

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #5180 (58b3bfc) into develop (8000195) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5180      +/-   ##
=============================================
- Coverage      48.47%   48.46%   -0.01%     
- Complexity      4136     4137       +1     
=============================================
  Files            743      743              
  Lines          26517    26517              
  Branches        3294     3294              
=============================================
- Hits           12853    12851       -2     
- Misses         12263    12271       +8     
+ Partials        1401     1395       -6     
Impacted Files Coverage Δ
...ing/boot/autoconfigure/SeataAutoConfiguration.java 0.00% <ø> (ø)
...utoconfigure/SeataDataSourceAutoConfiguration.java 0.00% <ø> (ø)
...rage/redis/store/RedisTransactionStoreManager.java 72.06% <0.00%> (-2.09%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (ø)
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (+0.63%) ⬆️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (+0.64%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.6.1 milestone Dec 21, 2022
@funky-eyes funky-eyes added module/spring spring module type: optimize module/seata-spring-boot-starter seata-spring-boot-starter module and removed module/spring spring module labels Dec 21, 2022
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 07753df into apache:develop Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants