Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix using @GlobalTransactional in provider ShouldNeverHappenException thrown #5472

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

pengten
Copy link
Contributor

@pengten pengten commented Mar 28, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

#5460
#5459

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2023

CLA assistant check
All committers have signed the CLA.

@slievrly slievrly changed the title bugfix: Using @GlobalTransactional in RM, ShouldNverHappenException will be thrown bugfix: fix using @GlobalTransactional in provider ShouldNverHappenException thrown Mar 29, 2023
@slievrly slievrly merged commit 6162198 into apache:develop Mar 29, 2023
@slievrly slievrly changed the title bugfix: fix using @GlobalTransactional in provider ShouldNverHappenException thrown bugfix: fix using @GlobalTransactional in provider ShouldNeverHappenException thrown Mar 29, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.7.0 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants