bugfix: global transaction hook repeat execute #5887
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5887 +/- ##
=============================================
- Coverage 48.90% 48.87% -0.04%
Complexity 4185 4185
=============================================
Files 793 793
Lines 28015 28028 +13
Branches 3418 3423 +5
=============================================
- Hits 13701 13698 -3
- Misses 12889 12900 +11
- Partials 1425 1430 +5
|
| } catch (Exception e) { | ||
| LOGGER.error("Failed execute afterCompletion in hook {}", e.getMessage(), e); | ||
| private void triggerAfterCompletion(GlobalTransaction tx) { | ||
| if (tx == null || tx.getGlobalTransactionRole() == GlobalTransactionRole.Launcher) { |
There was a problem hiding this comment.
which scene tx can be null ? it seems tx can not null from the invoke context
There was a problem hiding this comment.
这里不会为null，从事务模型上来说，事务开启失败了，是否需要调用completion
There was a problem hiding this comment.
我看其他的hook判断条件里面，都认为tx不会为null，所以都没有这个tx==null的判断，但是triggerAfterCompletion 这个需要有这个特殊处理。后面修改的人可能会疑惑
如果认为这里tx 也不会为null，是不是可以吧tx==null的条件去掉，和其他修改的地方保持一致？
I see in the conditions of other hook judgments that they all assume tx will not be null, so there is no tx==null condition. However, triggerAfterCompletion requires this special handling. The subsequent modifications may be confusing to people.
If we also assume that tx will not be null here, can we remove the tx==null condition and keep it consistent with other modifications?
There was a problem hiding this comment.
The hook is called by TransactionalTemplate, and the Participant's judgment is inside the class defaultGlobaltransaction, so I'm wondering again if I should underlay the hook call into defaultGlobaltransaction? Or the other way around, make defaultGlobaltransaction's behavior more pure, and all the prevention of duplicate calls and permission control is handled by TransactionalTemplate?
钩子是TransactionalTemplate调的，而Participant的判断是在defaultGlobaltransaction这个类里面的，所以我再想是否应该将hook的调用下层到defaultGlobaltransaction中？或者反过来，让defaultGlobaltransaction的行为更加单纯，所有的防止重复调用，权限控制都由TransactionalTemplate来处理？
角色判断修改为提前处理 |
|
|
funky-eyes
added
type: bug
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5595
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews