feature: support polardb-x 2.0 #5892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5892 +/- ##
=============================================
+ Coverage 48.75% 48.81% +0.06%
- Complexity 4128 4166 +38
=============================================
Files 775 793 +18
Lines 27924 28003 +79
Branches 3414 3417 +3
=============================================
+ Hits 13613 13671 +58
- Misses 12885 12907 +22
+ Partials 1426 1425 -1
|
slievrly
reviewed
Oct 3, 2023
| * | ||
| * @param connection db connection | ||
| */ | ||
| private void testMySQLAdaptiveType(Connection connection) { |
There was a problem hiding this comment.
Method names need to be more standardized, generally only UT will use the test name.
slievrly
reviewed
Oct 3, 2023
| * @param dbType origin db type | ||
| * @return adaptive db type | ||
| */ | ||
| private static String getAdaptiveDbType(String dbType) { |
There was a problem hiding this comment.
expect a common class to determine if it's a MySQL family of databases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Extending AT mode support for PolarDB-X 2.0.
Note: Transparent PolarDB-X support is currently available only in the form of MySQL inheritance, and DRDS partitioning may need to be supported in the future.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews