Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize some scripts related to Apollo #5926

Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Oct 12, 2023

optimize: optimize some scripts related to Apollo
优化一些与 Apollo 相关的脚本。

@wangliang181230 wangliang181230 changed the title optimize: optimize the script for apollo optimize some scripts related to Apollo Oct 12, 2023
@wangliang181230 wangliang181230 changed the title optimize some scripts related to Apollo optimize: optimize some scripts related to Apollo Oct 12, 2023
@wangliang181230 wangliang181230 added this to the 2.0.0 milestone Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5926 (afb7901) into 2.x (20662fd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #5926   +/-   ##
=========================================
  Coverage     48.80%   48.80%           
  Complexity     4485     4485           
=========================================
  Files           838      838           
  Lines         28774    28774           
  Branches       3594     3594           
=========================================
  Hits          14042    14042           
  Misses        13257    13257           
  Partials       1475     1475           

script/client/spring/application.properties Outdated Show resolved Hide resolved
script/client/spring/application.yml Outdated Show resolved Hide resolved
@wangliang181230
Copy link
Contributor Author

wangliang181230 commented Oct 16, 2023

@funky-eyes @slievrly PTAL

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 3baf2b4 into apache:2.x Oct 16, 2023
8 checks passed
@wangliang181230 wangliang181230 deleted the optimize-script-apollo-config-for-2.x branch October 17, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants