Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: compatible with tcc #6345

Merged
merged 12 commits into from
Mar 1, 2024
Merged

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Feb 15, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6344

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.06%. Comparing base (709bd30) to head (cd5a887).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6345      +/-   ##
============================================
+ Coverage     51.04%   51.06%   +0.01%     
- Complexity     5262     5264       +2     
============================================
  Files           934      934              
  Lines         33029    33029              
  Branches       4002     4002              
============================================
+ Hits          16860    16865       +5     
+ Misses        14503    14498       -5     
  Partials       1666     1666              
Files Coverage Δ
...m/tcc/interceptor/TccActionInterceptorHandler.java 68.85% <100.00%> (ø)

... and 5 files with indirect coverage changes

@slievrly
Copy link
Member

slievrly commented Feb 15, 2024

This PR involves some new and modified classes associated with PR #6342. I will review further after the processing of PR #6342 is completed.

@xingfudeshi
Copy link
Member Author

This PR involves some new and modified classes associated with PR #6342. I will review further after the processing of PR #6342 is completed.

Ok

@slievrly
Copy link
Member

@xingfudeshi some conflicts should be resolve.

@slievrly slievrly added this to the 2.1.0 milestone Feb 16, 2024
@xingfudeshi
Copy link
Member Author

@xingfudeshi some conflicts should be resolve.

Ok

…Compatible_with_tcc

# Conflicts:
#	compatible/pom.xml
#	compatible/src/main/java/io/seata/integration/tx/api/interceptor/ActionContextUtil.java
#	compatible/src/main/java/io/seata/rm/tcc/api/BusinessActionContext.java
#	compatible/src/main/java/io/seata/rm/tcc/api/BusinessActionContextParameter.java
@xingfudeshi
Copy link
Member Author

@slievrly Done.

compatible/pom.xml Outdated Show resolved Hide resolved

import static org.apache.seata.common.Constants.BEAN_NAME_SPRING_FENCE_CONFIG;

public class TccActionInterceptorHandler extends org.apache.seata.rm.tcc.interceptor.TccActionInterceptorHandler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the api the user is using
这不是用户所使用的api

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class handles annotations that start with io.seata. The annotation itself is just metadata.

@funky-eyes funky-eyes changed the title optimize:compatible with tcc optimize: compatible with tcc Mar 1, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 575ac12 into apache:2.x Mar 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatible with TCC module
4 participants