add: recycle buffer #704
Merged
add: recycle buffer #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #704 +/- ##
=============================================
+ Coverage 32.71% 32.72% +0.01%
- Complexity 895 896 +1
=============================================
Files 227 226 -1
Lines 8804 8797 -7
Branches 1061 1058 -3
=============================================
- Hits 2880 2879 -1
+ Misses 5598 5595 -3
+ Partials 326 323 -3
Continue to review full report at Codecov.
|
github-ygy
suggested changes
Mar 31, 2019
server/src/main/java/com/alibaba/fescar/server/session/BranchSession.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/alibaba/fescar/server/session/GlobalSession.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/alibaba/fescar/server/store/FileTransactionStoreManager.java
Outdated
Show resolved
Hide resolved
github-ygy
approved these changes
Mar 31, 2019
slievrly
reviewed
Apr 1, 2019
| @@ -299,8 +303,10 @@ public void run() { | |||
|
|
|||
| private boolean writeDataFile(byte[] bs) { | |||
| int retry = 0; | |||
| byte[] byWrite = new byte[bs.length + 4]; | |||
| ByteBuffer byteBuffer = ByteBuffer.wrap(byWrite); | |||
| ByteBuffer byteBuffer = wireteBuffer; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
In the code, there are many bytebuffers created but not reused. To reduce the number of YGC, ByteBuffer is reused.
I first read netty's recycle and implemented it. But this is a big change and will make the byte[] that was previously returned by SessionStorable into one of our custom objects, so I dropped it.
Then I looked at other store's system, such as RocketMq, which use ThreadLocal for caching,.it is simple and has very little momentum.
I ran the write part of WriteStoreTest, the VM parameter was -Xmx10m, the YGC was 3,400 times before the modification, and the YGC was 900 times after the modification.
I also changed the HeapByteBuffer used by Filechannel to DirectHeapByteBuffer.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
run write part of WriteStoreTest, VM parameter -Xmx10m
wathching jstat -gc pid 1000
Ⅴ. Special notes for reviews