add session size configuration #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #713 +/- ##
=============================================
- Coverage 32.8% 32.78% -0.03%
- Complexity 906 920 +14
=============================================
Files 227 229 +2
Lines 8851 8921 +70
Branches 1061 1083 +22
=============================================
+ Hits 2904 2925 +21
- Misses 5618 5653 +35
- Partials 329 343 +14
Continue to review full report at Codecov.
|
xingfudeshi
requested changes
Apr 3, 2019
server/src/main/java/com/alibaba/fescar/server/store/StoreConfig.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/alibaba/fescar/server/session/BranchSession.java
Outdated
Show resolved
Hide resolved
|
i left some comments |
done |
xingfudeshi
approved these changes
Apr 3, 2019
xingfudeshi
changed the title
slievrly
reviewed
Apr 3, 2019
github-ygy
reviewed
Apr 3, 2019
| */ | ||
| public class StoreConfig { | ||
|
|
||
| private static Configuration fileConfiguration = ConfigurationFactory.getInstance(); |
There was a problem hiding this comment.
final is better And change the name toUpperCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Enable users to configure gloab session, branch session and write buffer size
For branch session, if it is too large, it will first try to compress lockkey, and if it is larger than the maximum, an exception will be thrown.
I want to do the compression of RPC, but the RPC protocol is not very friendly. If we want to do the body compression of RPC, we need to adjust the protocol design
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews