Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:MergedSendRunnable can be closed by accident #725

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

CoffeeLatte007
Copy link
Contributor

Ⅰ. Describe what this PR did

#724.
1.In the MergedSendRunnable class, the connect method can throw a FrameworkException that causes the run method to permanently close.
2.MessageFuture will wait until the timeout, which I've optimized.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #725 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #725      +/-   ##
=============================================
- Coverage      32.75%   32.72%   -0.03%     
  Complexity       924      924              
=============================================
  Files            229      229              
  Lines           8937     8943       +6     
  Branches        1088     1090       +2     
=============================================
  Hits            2927     2927              
- Misses          5662     5668       +6     
  Partials         348      348
Impacted Files Coverage Δ Complexity Δ
...scar/core/rpc/netty/AbstractRpcRemotingClient.java 22.39% <0%> (-0.73%) 7 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89cbd56...7a2121f. Read the comment docs.

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

@xingfudeshi xingfudeshi self-requested a review April 4, 2019 08:50
@xingfudeshi xingfudeshi changed the title bugfix#724:MergedSendRunnable bugfix:MergedSendRunnable can be closed by accident Apr 4, 2019
@xingfudeshi xingfudeshi merged commit 3a786af into apache:develop Apr 4, 2019
@wangliang181230 wangliang181230 added this to the 0.4.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants