Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #662 repeated loading DataSourceManager #750

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

github-ygy
Copy link
Contributor

Ⅰ. Describe what this PR did

fix repeated loading DataSourceManager

Ⅱ. Does this pull request fix one issue?

#662 #667

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #750 into develop will increase coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #750      +/-   ##
=============================================
+ Coverage      32.31%   32.41%   +0.09%     
  Complexity       928      928              
=============================================
  Files            230      228       -2     
  Lines           9088     9060      -28     
  Branches        1103     1103              
=============================================
  Hits            2937     2937              
+ Misses          5804     5776      -28     
  Partials         347      347
Impacted Files Coverage Δ Complexity Δ
...libaba/fescar/rm/datasource/DataSourceManager.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../com/alibaba/fescar/rm/datasource/AsyncWorker.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a2824...12d41fc. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants