Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:code optimization of EurekaRegistryServiceImpl #754

Merged
merged 3 commits into from
Apr 10, 2019
Merged

bugfix:code optimization of EurekaRegistryServiceImpl #754

merged 3 commits into from
Apr 10, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

1.Remove redundant static keywords
2.initial size of map.
3.lazy load of some object.

Ⅱ. Does this pull request fix one issue?

#753

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration testing.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #754 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #754   +/-   ##
==========================================
  Coverage      32.25%   32.25%           
  Complexity       926      926           
==========================================
  Files            228      228           
  Lines           9058     9058           
  Branches        1102     1101    -1     
==========================================
  Hits            2922     2922           
  Misses          5788     5788           
  Partials         348      348
Impacted Files Coverage Δ Complexity Δ
.../discovery/registry/EurekaRegistryServiceImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../alibaba/fescar/config/ZookeeperConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18c46d...a2701f0. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangthen zhangthen merged commit ec72f20 into apache:develop Apr 10, 2019
@wangliang181230 wangliang181230 added this to the 0.4.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants