-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:code optimization of EurekaRegistryServiceImpl #754
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #754 +/- ##
==========================================
Coverage 32.25% 32.25%
Complexity 926 926
==========================================
Files 228 228
Lines 9058 9058
Branches 1102 1101 -1
==========================================
Hits 2922 2922
Misses 5788 5788
Partials 348 348
Continue to review full report at Codecov.
|
config/src/main/java/com/alibaba/fescar/config/ZookeeperConfiguration.java
Outdated
Show resolved
Hide resolved
discovery/src/main/java/com/alibaba/fescar/discovery/registry/EurekaRegistryServiceImpl.java
Outdated
Show resolved
Hide resolved
discovery/src/main/java/com/alibaba/fescar/discovery/registry/EurekaRegistryServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Ⅰ. Describe what this PR did
1.Remove redundant static keywords
2.initial size of map.
3.lazy load of some object.
Ⅱ. Does this pull request fix one issue?
#753
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews