Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix FileConfiguration config listener logic #772

Merged
merged 4 commits into from
Apr 15, 2019

Conversation

liujianhuiouc
Copy link
Contributor

Ⅰ. Describe what this PR did

�when listeners change, add or remove the config correspond to the config id, as the config change, it mean current config different from the config in listenconfigmap, the listener match that config should be called

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #772 into develop will increase coverage by 0.07%.
The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #772      +/-   ##
=============================================
+ Coverage      32.67%   32.74%   +0.07%     
  Complexity       936      936              
=============================================
  Files            228      228              
  Lines           9102     9103       +1     
  Branches        1108     1108              
=============================================
+ Hits            2974     2981       +7     
+ Misses          5772     5764       -8     
- Partials         356      358       +2
Impacted Files Coverage Δ Complexity Δ
...a/com/alibaba/fescar/config/FileConfiguration.java 54.28% <75%> (+6.2%) 10 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37eed2...b0e5597. Read the comment docs.

Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a comment

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the title.it will be a commit log.please refer others PR.

@liujianhuiouc liujianhuiouc changed the title fix #771 fix #771: fix FileConfiguration config listener logic Apr 14, 2019
@liujianhuiouc
Copy link
Contributor Author

Please modify the title.it will be a commit log.please refer others PR.

done

@xingfudeshi xingfudeshi changed the title fix #771: fix FileConfiguration config listener logic bugfix:fix FileConfiguration config listener logic Apr 15, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.LGTM.

@xingfudeshi xingfudeshi merged commit 117f3da into apache:develop Apr 15, 2019
@liujianhuiouc liujianhuiouc deleted the issue-771 branch April 15, 2019 01:55
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants