-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix FileConfiguration config listener logic #772
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #772 +/- ##
=============================================
+ Coverage 32.67% 32.74% +0.07%
Complexity 936 936
=============================================
Files 228 228
Lines 9102 9103 +1
Branches 1108 1108
=============================================
+ Hits 2974 2981 +7
+ Misses 5772 5764 -8
- Partials 356 358 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the title.it will be a commit log.please refer others PR.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.LGTM.
Ⅰ. Describe what this PR did
�when listeners change, add or remove the config correspond to the config id, as the config change, it mean current config different from the config in listenconfigmap, the listener match that config should be called
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews