-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimizes the structure of config module and discovery module #774
optimizes the structure of config module and discovery module #774
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #774 +/- ##
============================================
+ Coverage 32.73% 34.4% +1.66%
+ Complexity 936 889 -47
============================================
Files 228 215 -13
Lines 9103 8299 -804
Branches 1108 996 -112
============================================
- Hits 2980 2855 -125
+ Misses 5766 5104 -662
+ Partials 357 340 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
config/fescar-config-core/src/main/java/com/alibaba/fescar/config/FileConfiguration.java
Show resolved
Hide resolved
LGTM |
Ⅰ. Describe what this PR did
In practical applications, for configuration centers and registries, multiple types are not used at the same time, such as Zookeeper, Nacos and so on. Therefore, these dependencies should be optional, allowing users to decide what dependencies to download.
So,this PR provides a way for users to decide which dependencies to use and download by themselves. By default, File-based configuration and registry have been provided.
for example:
if you need only the support for Spring,you can import the following dependency
Maven dependency
As described before,by default,only File-based configuration and registry will be provided.so,in registry.conf,the value of type for both registry and config should be file.
In another case,you may want to use the Nacos as the configuration center,and the consul for registry,then you just need import two more dependencies as bellow:
and modify the value in registry.conf,the final configuration should look like the following:
In addition, you can use the following two dependencies, which import all Seata-supported configuration centers and registries.
Ⅱ. Does this pull request fix one issue?
#760
#755
#601
Ⅲ. Why don't you add test cases (unit test/integration test)?
i have done the integration testing.and,i didn't modify the original implementation.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews