Change the startup parameters of seata-server to support database-storage #790

zhangthen · 2019-04-15T03:18:43Z

slievrly · 2019-04-15T04:28:27Z

server/src/main/resources/file.conf

+  # globe session size , if exceeded throws exceptions
+  max-global-session-size = 512
+  # file buffer size , if exceeded allocate new buffer
+  file-write-buffer-cache-size = 16384


should move to under the file node？also modify ConfigurationKey in the code.

should move to under the file node？also modify ConfigurationKey in the code.

done.

codecov-io · 2019-04-15T05:44:02Z

Codecov Report

Merging #790 into develop will decrease coverage by 0.28%.
The diff coverage is 11.25%.

@@              Coverage Diff              @@
##             develop     #790      +/-   ##
=============================================
- Coverage      34.22%   33.93%   -0.29%     
+ Complexity       888      886       -2     
=============================================
  Files            215      217       +2     
  Lines           8301     8368      +67     
  Branches         996     1010      +14     
=============================================
- Hits            2841     2840       -1     
- Misses          5119     5184      +65     
- Partials         341      344       +3

Impacted Files	Coverage Δ	Complexity Δ
...ibaba/fescar/core/constants/ConfigurationKeys.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...libaba/fescar/common/exception/StoreException.java	`0% <0%> (ø)`	`0 <0> (?)`
...rc/main/java/com/alibaba/fescar/server/Server.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
.../java/com/alibaba/fescar/core/store/StoreMode.java	`0% <0%> (ø)`	`0 <0> (?)`
...va/com/alibaba/fescar/common/util/StringUtils.java	`7.57% <0%> (-13.26%)`	`6 <0> (ø)`
...a/com/alibaba/fescar/server/store/StoreConfig.java	`80% <100%> (ø)`	`4 <3> (ø)`	⬇️
...m/alibaba/fescar/server/session/SessionHolder.java	`58.82% <54.54%> (-5.24%)`	`14 <3> (-1)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba3f7a...7c1ff79. Read the comment docs.

slievrly · 2019-04-15T05:53:29Z

server/src/main/java/com/alibaba/fescar/server/session/SessionHolder.java

-            ROOT_SESSION_MANAGER = new DefaultSessionManager(ROOT_SESSION_MANAGER_NAME);
+    public static void init(String mode) throws IOException {
+        if(StringUtils.isBlank(mode)){
+            mode = CONFIG.getConfig("store.mode");


store.mode，store.file.dir-> static final, new file add copyright

store.mode，store.file.dir-> static final, new file add copyright

done.

CoffeeLatte007 · 2019-04-15T06:42:48Z

core/src/main/java/com/alibaba/fescar/core/constants/ConfigurationKeys.java

+    /**
+     * The constant STORE_FILE_PREFIX
+     */
+    public static final String STORE_FILE_PREFIX = "file.";


lack DB_PREFIX

Maybe STORE_FILE_PREFIX = STORE_PREFIX + "file."?
not STORE_FILE_PREFIX = "file."

@CoffeeLatte007 done, exclude DB_PREFIX which is in another PR after 0.5.0

CoffeeLatte007 · 2019-04-15T06:54:34Z

core/src/main/java/com/alibaba/fescar/core/constants/ConfigurationKeys.java

@@ -71,5 +87,5 @@
    /**
     * The constant SERVICE_SESSION_RELOAD_READ_SIZE
     */
-    public static final String SERVICE_SESSION_RELOAD_READ_SIZE = STORE_PREFIX + "session.reload.read_size";
+    public static final String SERVICE_SESSION_RELOAD_READ_SIZE = STORE_PREFIX + STORE_FILE_PREFIX + "session.reload.read_size";


forget update
STORE_FILE_PREFIX + "session.reload.read_size";

CoffeeLatte007 · 2019-04-15T06:57:39Z

is's good to me . but it has conflicts

# Conflicts: # core/src/main/java/com/alibaba/fescar/core/constants/ConfigurationKeys.java

CoffeeLatte007

LGTM

slievrly · 2019-04-15T09:30:52Z

core/src/main/java/com/alibaba/fescar/core/store/StoreMode.java

+                return sm;
+            }
+        }
+        return null;


if someone start server like sh startup.sh 8091 /home/admin/ 192.168.0.1 ,I think it should be throw IllegalArgumentException, not return null and use default file mode.

slievrly · 2019-04-15T09:31:32Z

server/src/test/java/com/alibaba/fescar/server/store/SessionStoreTest.java

@@ -69,7 +69,8 @@ public void clean() throws Exception {
     */
    @Test
    public void testRestoredFromFile() throws Exception {
-        SessionHolder.init(".");
+//        SessionHolder.init(".");


directly delete

directly delete

done.

zhangthen and others added 5 commits April 2, 2019 14:43

modify the args of main for db store

487eedb

Merge remote-tracking branch 'upstream/develop' into develop-args

207b301

Merge remote-tracking branch 'upstream/develop' into develop-args

e0591e0

remove TCC chinese comments

4b482ea

remove unused code files

28d45d8

zhangthen requested review from slievrly and sharajava April 15, 2019 03:20

zhangthen added this to the 0.5.0 milestone Apr 15, 2019

zhangthen added 2 commits April 15, 2019 11:37

fix test case problems

1be19d7

StringUtils.toString

227aad6

slievrly reviewed Apr 15, 2019

View reviewed changes

fix test case problems

90b4634

zhangthen added 2 commits April 15, 2019 13:45

change session size config

6256c6b

change default configs of db store

a865172

slievrly reviewed Apr 15, 2019

View reviewed changes

fix review problems

078e05a

CoffeeLatte007 reviewed Apr 15, 2019

View reviewed changes

fix review problems

99fa534

CoffeeLatte007 reviewed Apr 15, 2019

View reviewed changes

fix review problems

e1cdcdf

Merge remote-tracking branch 'upstream/develop' into develop-args

a905d7b

# Conflicts: # core/src/main/java/com/alibaba/fescar/core/constants/ConfigurationKeys.java

CoffeeLatte007 approved these changes Apr 15, 2019

View reviewed changes

slievrly reviewed Apr 15, 2019

View reviewed changes

zhangthen added 3 commits April 16, 2019 14:33

Merge remote-tracking branch 'upstream/develop' into develop-args

b98d5e2

remove unused code

dd2c78e

reject file-path store mode

7c1ff79

ujjboy approved these changes Apr 16, 2019

View reviewed changes

zhangthen merged commit e888f58 into apache:develop Apr 16, 2019

zhangthen deleted the develop-args branch April 16, 2019 07:05

fescar-robot mentioned this pull request Apr 19, 2019

[WeeklyReport] Weekly report for Seata 2019-4-12 to 2019-4-19 #847

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the startup parameters of seata-server to support database-storage #790

Change the startup parameters of seata-server to support database-storage #790

zhangthen commented Apr 15, 2019

slievrly Apr 15, 2019

zhangthen Apr 15, 2019

codecov-io commented Apr 15, 2019 •

edited

slievrly Apr 15, 2019

zhangthen Apr 15, 2019

CoffeeLatte007 Apr 15, 2019

CoffeeLatte007 Apr 15, 2019

zhangthen Apr 15, 2019

CoffeeLatte007 Apr 15, 2019

CoffeeLatte007 commented Apr 15, 2019

CoffeeLatte007 left a comment

slievrly Apr 15, 2019

slievrly Apr 15, 2019

zhangthen Apr 16, 2019

Change the startup parameters of seata-server to support database-storage #790

Change the startup parameters of seata-server to support database-storage #790

Conversation

zhangthen commented Apr 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Apr 15, 2019 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CoffeeLatte007 commented Apr 15, 2019

CoffeeLatte007 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Apr 15, 2019 •

edited