Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace magic judgement of timeout status with status enum #791

Merged
merged 3 commits into from
Apr 16, 2019
Merged

replace magic judgement of timeout status with status enum #791

merged 3 commits into from
Apr 16, 2019

Conversation

leizhiyuan
Copy link
Contributor

Ⅰ. Describe what this PR did

replace magic judge of timeout status with status enum, Timeout is confused here.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

It does not need a test case, we can ensure by the code

Ⅳ. Describe how to verify it

review

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #791 into develop will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #791      +/-   ##
=============================================
- Coverage       34.4%   34.23%   -0.18%     
+ Complexity       889      888       -1     
=============================================
  Files            215      215              
  Lines           8300     8301       +1     
  Branches         996      996              
=============================================
- Hits            2856     2842      -14     
- Misses          5104     5117      +13     
- Partials         340      342       +2
Impacted Files Coverage Δ Complexity Δ
...alibaba/fescar/server/coordinator/DefaultCore.java 27.46% <0%> (ø) 11 <0> (ø) ⬇️
...m/alibaba/fescar/server/session/SessionHelper.java 72.41% <0%> (-2.59%) 6 <1> (+1)
...om/alibaba/fescar/core/rpc/netty/ShutdownHook.java 56.25% <0%> (-25%) 6% <0%> (-2%)
...scar/core/rpc/netty/AbstractRpcRemotingClient.java 17.7% <0%> (-2.88%) 7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e53c3...85d7a4b. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi self-requested a review April 16, 2019 01:17
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants