optimize file write performance #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #795 +/- ##
============================================
- Coverage 37.75% 37.16% -0.6%
+ Complexity 1033 1024 -9
============================================
Files 224 224
Lines 8796 8882 +86
Branches 1064 1065 +1
============================================
- Hits 3321 3301 -20
- Misses 5081 5196 +115
+ Partials 394 385 -9
Continue to review full report at Codecov.
|
xingfudeshi
reviewed
Apr 24, 2019
xingfudeshi
reviewed
Apr 24, 2019
xingfudeshi
reviewed
Apr 24, 2019
# Conflicts: # core/src/main/java/io/seata/core/exception/TransactionExceptionCode.java # server/src/main/java/io/seata/server/store/FileTransactionStoreManager.java
# Conflicts: # core/src/main/java/io/seata/core/exception/TransactionExceptionCode.java # server/src/main/java/io/seata/server/store/FileTransactionStoreManager.java
slievrly
reviewed
Apr 29, 2019
| if (!writeDataFile(new TransactionWriteStore(session, logOperation).encode())) { | ||
| return false; | ||
| } | ||
| lastModifiedTime = System.currentTimeMillis(); |
There was a problem hiding this comment.
why not get file. lastModifiedTime?
There was a problem hiding this comment.
why use file. lastModifiedTime? I'm not sure it get the lastModifiedTime from disk every time
|
|
||
| public void waitForFlush(long timeout) { | ||
| try { | ||
| this.countDownLatch.await(timeout, TimeUnit.MILLISECONDS); |
There was a problem hiding this comment.
i think it should not check return value as rocketmq. even it happend time out , we should not block our process
|
|
||
| private void closeAndFlush(CloseFileRequest req) { | ||
| long diff = FILE_TRX_NUM.get() - FILE_FLUSH_NUM.get(); |
There was a problem hiding this comment.
call syncFlush()? param StoreRequest
There was a problem hiding this comment.
syncFlush will weakUp. Close does not need
server/src/main/java/io/seata/server/store/FileTransactionStoreManager.java
Show resolved
Hide resolved
nick-tan
pushed a commit
to nick-tan/seata
that referenced
this pull request
Jul 12, 2019
* optimize fil write performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
mac: 2.2 GHz Intel Core i7. 4 core .
per_thread_write_file = per_thread_trx_num * 9
===========new file write aync mode====================
thread nums:1, per_thread_trx_num:65535 ,cost2600
thread nums:4, per_thread_trx_num:65535 ,cost13329
thread nums:8, per_thread_trx_num:65535 ,cost27613
thread nums:16, per_thread_trx_num:65535 ,cost57764
===========old file write aync mode====================
thread nums:1, per_thread_trx_num:65535 ,cost17816
thread nums:4, per_thread_trx_num:65535 ,cost42218
thread nums:8, per_thread_trx_num:65535 ,cost87016
thread nums:16, per_thread_trx_num:65535 ,cost176943
Performance improved by more than 60%
set trx_time_out = 1000ms, each saveHistory will save 3000 data.
===========new saveHistory ====================
thread nums:16, per_thread_trx_num:65535 ,cost 60559
===========old saveHistory ====================
thread nums:16, per_thread_trx_num:65535 ,cost90189
Ⅱ. Does this pull request fix one issue?
#858
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews