Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change groupId,artifactId, and package in 0.5.0 #809

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Change groupId,artifactId, and package in 0.5.0 #809

merged 4 commits into from
Apr 17, 2019

Conversation

zhangthen
Copy link
Contributor

#806

I will modify the sample projects soon.

@zhangthen zhangthen added this to the 0.5.0 milestone Apr 16, 2019
@zhangthen zhangthen requested a review from wgs13579 April 17, 2019 02:45
wgs13579
wgs13579 approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@wgs13579 wgs13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz confirm the test done well

lovepoem
lovepoem approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit a39b943 into apache:develop Apr 17, 2019
@fescar-robot fescar-robot mentioned this pull request Apr 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovepoem lovepoem lovepoem approved these changes

@wgs13579 wgs13579 wgs13579 approved these changes

@slievrly slievrly Awaiting requested review from slievrly

@sharajava sharajava Awaiting requested review from sharajava

@ujjboy ujjboy Awaiting requested review from ujjboy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.*
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhangthen @lovepoem @wgs13579