fix #819 add roll back on for GlobalTransaction #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure_tx_rollback # Conflicts: # spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java # tm/src/main/java/io/seata/tm/api/TransactionalTemplate.java # tm/src/test/java/io/seata/tm/api/TransactionTemplateTest.java
…ure_tx_rollback # Conflicts: # spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java # tm/src/main/java/io/seata/tm/api/TransactionalTemplate.java # tm/src/test/java/io/seata/tm/api/TransactionTemplateTest.java
Codecov Report
@@ Coverage Diff @@
## develop #820 +/- ##
============================================
+ Coverage 37.74% 38.2% +0.46%
- Complexity 974 1008 +34
============================================
Files 217 220 +3
Lines 8364 8446 +82
Branches 1002 1016 +14
============================================
+ Hits 3157 3227 +70
- Misses 4826 4835 +9
- Partials 381 384 +3
Continue to review full report at Codecov.
|
github-ygy
requested review from
slievrly,
xingfudeshi,
CoffeeLatte007 and
fescar-robot
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Apr 18, 2019
nick-tan
pushed a commit
to nick-tan/seata
that referenced
this pull request
Jul 12, 2019
* fix apache#819 add roll back on for GlobalTransaction * Merge branch 'develop' of https://github.com/alibaba/fescar into feature_tx_rollback # Conflicts: # spring/src/main/java/io/seata/spring/annotation/GlobalTransactionalInterceptor.java # tm/src/main/java/io/seata/tm/api/TransactionalTemplate.java # tm/src/test/java/io/seata/tm/api/TransactionTemplateTest.java * format code and add test * format code and add test * for review and thanks reviewers * update pkg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add roll back on for GlobalTransaction
roll back when we throw the exception what we want .
Ⅱ. Does this pull request fix one issue?
fix #819
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews