Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:RM delete delay registration #830

Merged
merged 12 commits into from
Apr 23, 2019
Merged

bugfix:RM delete delay registration #830

merged 12 commits into from
Apr 23, 2019

Conversation

philoli11
Copy link
Contributor

Ⅰ. Describe what this PR did

Delete the delayed registration of RM, and resolve the bug that the rollback retry fails after the service restarts.

Ⅱ. Does this pull request fix one issue?

#818

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't change completely, but I will modify it later.

@slievrly slievrly changed the title fix:RM delete delay registration bugfix:RM delete delay registration Apr 18, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check TableMetaTest

@philoli11
Copy link
Contributor Author

check TableMetaTest

done

@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #830 into develop will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #830      +/-   ##
=============================================
+ Coverage      38.28%   38.67%   +0.39%     
- Complexity      1013     1026      +13     
=============================================
  Files            220      220              
  Lines           8504     8498       -6     
  Branches        1023     1023              
=============================================
+ Hits            3256     3287      +31     
+ Misses          4861     4823      -38     
- Partials         387      388       +1
Impacted Files Coverage Δ Complexity Δ
...n/java/io/seata/rm/datasource/DataSourceProxy.java 65.21% <100%> (+20.38%) 6 <0> (+2) ⬆️
.../main/java/io/seata/rm/datasource/AsyncWorker.java 15.78% <0%> (+15.78%) 4% <0%> (+4%) ⬆️
...java/io/seata/rm/datasource/DataSourceManager.java 28.33% <0%> (+28.33%) 7% <0%> (+7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31b824...f1290e8. Read the comment docs.

@zhangthen zhangthen added this to the 0.6.0 milestone Apr 18, 2019
@xingfudeshi xingfudeshi self-requested a review April 19, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants