An optimization about MessageFuture #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge for name change
Codecov Report
@@ Coverage Diff @@
## develop #831 +/- ##
=============================================
+ Coverage 38.04% 38.05% +0.01%
+ Complexity 1006 1005 -1
=============================================
Files 220 220
Lines 8449 8452 +3
Branches 1016 1015 -1
=============================================
+ Hits 3214 3216 +2
- Misses 4850 4852 +2
+ Partials 385 384 -1
Continue to review full report at Codecov.
|
| @@ -26,13 +29,12 @@ | |||
| * @author jimin.jm @alibaba-inc.com | |||
| * @date 2018 /10/9 | |||
| */ | |||
| public class MessageFuture { | |||
| public class MessageFuture{ | |||
| result = origin.get(timeout, unit); | ||
| } catch (ExecutionException e) { | ||
| throw new ShouldNeverHappenException("Should not get results in a multi-threaded environment", e); | ||
| } catch (TimeoutException e){ |
github-ygy
suggested changes
Apr 19, 2019
github-ygy
suggested changes
Apr 19, 2019
github-ygy
approved these changes
Apr 19, 2019
|
@CoffeeLatte007 do u have any other questions ？ |
nick-tan
pushed a commit
to nick-tan/seata
that referenced
this pull request
Jul 12, 2019
Use CompletableFuture instead CountDownLatch in MessageFuture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
In the MessageFuture class, it is currently implemented using CountDownLatch.
This synchronization method is relatively heavy, we should replace it with CompletableFuture to achieve.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews