fix bug for non SQLException not thrown #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizhiyuan
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #834 +/- ##
==========================================
Coverage 38.02% 38.02%
Complexity 1006 1006
==========================================
Files 220 220
Lines 8446 8446
Branches 1016 1016
==========================================
Hits 3212 3212
Misses 4848 4848
Partials 386 386
Continue to review full report at Codecov.
|
github-ygy
suggested changes
Apr 19, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/exec/ExecuteTemplate.java
Outdated
Show resolved
Hide resolved
github-ygy
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Exception which not SQLException， should also be thrown
Ⅱ. Does this pull request fix one issue?
fixes #816
Ⅲ. Why don't you add test cases (unit test/integration test)?
no need
Ⅳ. Describe how to verify it
cr
Ⅴ. Special notes for reviews